Page MenuHomePhabricator
Differential D3967

Consistently log CValidationState on failure
ClosedPublic
Actions

Authored by fpelliccioni on Aug 28 2019, 20:39.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING51fbdf464a64: Consistently log CValidationState on failure
rABC51fbdf464a64: Consistently log CValidationState on failure
Summary

Backport of Bitcoin Core PR13020
https://github.com/bitcoin/bitcoin/pull/13020

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-4741ca5dc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7272
Build 12589: Bitcoin ABC Buildbot (legacy)
Build 12588: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Aug 28 2019, 20:39
Owners added a reviewer: Restricted Owners Package.Aug 28 2019, 20:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 20:39
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 28 2019, 20:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni added a reviewer: Fabien.Aug 28 2019, 20:42
teamcity added a comment.Aug 28 2019, 20:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7272: Diff 11011.Aug 28 2019, 20:47
deadalnix accepted this revision.Aug 30 2019, 13:08
This revision is now accepted and ready to land.Aug 30 2019, 13:08
Closed by commit rABC51fbdf464a64: Consistently log CValidationState on failure (authored by Ben Woosley <ben.woosley@gmail.com>, committed by fpelliccioni). · Explain WhySep 2 2019, 17:36
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC51fbdf464a64: Consistently log CValidationState on failure.
fpelliccioni added a commit: rSTAGING51fbdf464a64: Consistently log CValidationState on failure.Sep 19 2019, 02:06

Revision Contents
Changeset List

PathSize
src/
3 lines
14 lines
test/
3 lines
44 lines

Diff 11011

View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/validation.cpp

Loading...