Paths

Table of Contentst

Standardize inline and static declaration order.
ClosedPublic
Actions

Authored by deadalnix on Jul 31 2017, 12:34.

Details

Reviewers

freetrader
CCulianu

Group Reviewers

Restricted Project

Commits

rSTAGINGf085891732bc: Standardize inline and static declaration order.
rABCf085891732bc: Standardize inline and static declaration order.

Summary

Just readability patch. No semantic change. It seems like clang-format likes it better as well.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

statictype

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 636
Build 636: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 31 2017, 12:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2017, 12:34

Rebase, ping.

Jesus wept. Core... core.. core...

Really.. REALLY!? REALLY?!?!!1one

I can't.. even.. believe.. this was in the original bitcoin sources.

So ugly.

YES. Thank you for this cleanup. OMFG. I almost wanted to vomit at the original. So much suck.

int static foo;

WHO DOES THIS?! I have been reading C sources since 1990 and .. even esoteric stuff like K&R style function declarations have a place. But this.. this. Noone. Ever. Codes this way.

Thank you for fixing this!!!!!!!!!!!

(PS: Went over all the changes visually, as well as compiled and works.)

This revision is now accepted and ready to land.Aug 3 2017, 17:37

Closed by commit rABCf085891732bc: Standardize inline and static declaration order. (authored by deadalnix, committed by deadalnix). · Explain WhyAug 3 2017, 19:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

chain.cpp

4 lines

compat.h

2 lines

crypto/

20 lines

498 lines

252 lines

339 lines

425 lines

2 lines

2 lines

2 lines

10 lines

2 lines

6 lines

4 lines

2 lines

qt/

guiutil.cpp

6 lines

script/

interpreter.cpp

10 lines

sync.h

8 lines

test/

30 lines

6 lines

4 lines

10 lines

wallet/

db.h

2 lines

rpcdump.cpp

6 lines

Diff 1013

View Options

src/chain.cpp

View Options

src/compat.h

View Options

src/crypto/common.h

View Options

src/crypto/ripemd160.cpp

View Options

src/crypto/sha1.cpp

View Options

src/crypto/sha256.cpp

View Options

src/crypto/sha512.cpp

View Options

src/init.cpp

View Options

src/key.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/netaddress.cpp

View Options

src/netbase.cpp

View Options

src/protocol.cpp

View Options

src/pubkey.h

View Options

src/qt/guiutil.cpp

View Options

src/script/interpreter.cpp

View Options

src/sync.h

View Options

src/test/coins_tests.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/netbase_tests.cpp

View Options

src/validation.cpp

View Options

src/wallet/db.h

View Options

Standardize inline and static declaration order.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1013

src/chain.cpp

src/compat.h

src/crypto/common.h

src/crypto/ripemd160.cpp

src/crypto/sha1.cpp

src/crypto/sha256.cpp

src/crypto/sha512.cpp

src/init.cpp

src/key.h

src/net.cpp

src/net_processing.cpp

src/netaddress.cpp

src/netbase.cpp

src/protocol.cpp

src/pubkey.h

src/qt/guiutil.cpp

src/script/interpreter.cpp

src/sync.h

src/test/coins_tests.cpp

src/test/compress_tests.cpp

src/test/netbase_tests.cpp

src/validation.cpp

src/wallet/db.h

src/wallet/rpcdump.cpp

Standardize inline and static declaration order.
ClosedPublic
Actions

Revision Contents
Changeset List