Page MenuHomePhabricator
Differential D4033

Remove ReadBlockFromDisk's dependency on Config
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2019, 12:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING31fa4da44001: Remove ReadBlockFromDisk's dependency on Config
rABC31fa4da44001: Remove ReadBlockFromDisk's dependency on Config
Summary

This end up removing the dependency from GetTransaction and ReplayBlocks.

Depends on D4032

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
readblockfromdisc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7384
Build 12811: Bitcoin ABC Buildbot (legacy)
Build 12810: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2019, 12:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 12:02
teamcity added a comment.Sep 11 2019, 12:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 12:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7384: Diff 11189.Sep 11 2019, 12:11
Fabien accepted this revision.Sep 11 2019, 14:45
This revision is now accepted and ready to land.Sep 11 2019, 14:45
Closed by commit rABC31fa4da44001: Remove ReadBlockFromDisk's dependency on Config (authored by deadalnix). · Explain WhySep 11 2019, 15:47
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC31fa4da44001: Remove ReadBlockFromDisk's dependency on Config.
deadalnix added a commit: rSTAGING31fa4da44001: Remove ReadBlockFromDisk's dependency on Config.Sep 19 2019, 02:14
PiRK mentioned this in D16259: validation: deduplicate forward declaration of Consensus::Params.May 31 2024, 15:47
PiRK mentioned this in rABC8e839c67d4b9: validation: deduplicate forward declaration of Consensus::Params.Jun 3 2024, 13:31

Revision Contents
Changeset List

PathSize
src/
index/
5 lines
3 lines
9 lines
6 lines
rpc/
9 lines
12 lines
17 lines
58 lines
wallet/
4 lines
2 lines
zmq/
4 lines

Diff 11189

View Options

src/index/base.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/zmq/zmqpublishnotifier.cpp

Loading...