Page MenuHomePhabricator

Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py
ClosedPublic

Authored by nakihito on Oct 23 2019, 01:40.

Details

Summary

There was a bug discovered by the addition of D4255 affecting ASAN
builds. See core issue:
https://github.com/bitcoin/bitcoin/issues/14163. The exact solution
for this bug is unclear, but will likely require the backporting of at
least the following PRs and their dependencies from Core:

https://github.com/bitcoin/bitcoin/pull/13161/
https://github.com/bitcoin/bitcoin/pull/12493/
https://github.com/bitcoin/bitcoin/pull/14320/
https://github.com/bitcoin/bitcoin/pull/14552/
https://github.com/bitcoin/bitcoin/pull/14760/
https://github.com/bitcoin/bitcoin/pull/11911/

Suppression of the error is a temporary fix until the above backports
are complete. This is the same approach that Core took. See
https://github.com/bitcoin/bitcoin/pull/14794/files#diff-354f30a63fb0907d4ad57269548329e3R111
for the initial suppression and
https://github.com/bitcoin/bitcoin/pull/15303/files#diff-354f30a63fb0907d4ad57269548329e3L128
for its removal.

Test Plan

From the build dir:

export ABC_BUILD_NAME=build-asan
../contrib/teamcity/build-configurations.sh

ASAN build through TeamCity

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SuppressASANWarning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7839
Build 13699: Bitcoin ABC Buildbot (legacy)
Build 13698: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 23 2019, 01:40

Discussed offline: there is no working lsan suppression for the issue.

This revision is now accepted and ready to land.Oct 23 2019, 20:29