Page MenuHomePhabricator
Differential D4281

Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py
ClosedPublic
Actions

Authored by nakihito on Oct 23 2019, 01:40.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py
rABC8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py
Summary

There was a bug discovered by the addition of D4255 affecting ASAN
builds. See core issue:
https://github.com/bitcoin/bitcoin/issues/14163. The exact solution
for this bug is unclear, but will likely require the backporting of at
least the following PRs and their dependencies from Core:

https://github.com/bitcoin/bitcoin/pull/13161/
https://github.com/bitcoin/bitcoin/pull/12493/
https://github.com/bitcoin/bitcoin/pull/14320/
https://github.com/bitcoin/bitcoin/pull/14552/
https://github.com/bitcoin/bitcoin/pull/14760/
https://github.com/bitcoin/bitcoin/pull/11911/

Suppression of the error is a temporary fix until the above backports
are complete. This is the same approach that Core took. See
https://github.com/bitcoin/bitcoin/pull/14794/files#diff-354f30a63fb0907d4ad57269548329e3R111
for the initial suppression and
https://github.com/bitcoin/bitcoin/pull/15303/files#diff-354f30a63fb0907d4ad57269548329e3L128
for its removal.

Test Plan

From the build dir:

export ABC_BUILD_NAME=build-asan
../contrib/teamcity/build-configurations.sh

ASAN build through TeamCity

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 23 2019, 01:40
Owners added a reviewer: Restricted Owners Package.Oct 23 2019, 01:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 01:40
nakihito planned changes to this revision.Oct 23 2019, 01:40
teamcity added a comment.Oct 23 2019, 01:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Oct 23 2019, 01:48
teamcity added a comment.Oct 23 2019, 01:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7839: Diff 13650.Oct 23 2019, 01:50
nakihito requested review of this revision.Oct 23 2019, 20:26
Fabien accepted this revision.Oct 23 2019, 20:29

Discussed offline: there is no working lsan suppression for the issue.

This revision is now accepted and ready to land.Oct 23 2019, 20:29
teamcity added a comment.Oct 23 2019, 20:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Oct 23 2019, 20:40
jasonbcox accepted this revision.Oct 23 2019, 20:41
teamcity added a comment.Oct 23 2019, 20:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py (authored by nakihito). · Explain WhyOct 24 2019, 07:38
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.
nakihito added a commit: rSTAGING8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.Apr 7 2020, 21:29

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines

Diff 13680

View Options

contrib/teamcity/build-configurations.sh

Loading...