Page MenuHomePhabricator

Merge #14025: p2p: Remove dead code for nVersion=10300

Authored by nakihito on Nov 15 2019, 06:14.



fa74d3d720 qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099ceb7 p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434

Backport of Core PR14025

Also removed relevant obsolete code from seeder.

Reviewer note: the net_processing changes we made in D333

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Nov 15 2019, 06:14
nakihito requested review of this revision.
nakihito edited the test plan for this revision. (Show Details)
deadalnix requested changes to this revision.Nov 15 2019, 14:41
deadalnix added inline comments.
122 ↗(On Diff #14141)

It looks like these are also not relevent anymore, as per the test.

This revision now requires changes to proceed.Nov 15 2019, 14:41

Removed some more obsolete code from the seeder.

This revision is now accepted and ready to land.Nov 15 2019, 22:11