Page MenuHomePhabricator
Differential D4449

Merge #14025: p2p: Remove dead code for nVersion=10300
ClosedPublic
Actions

Authored by nakihito on Nov 15 2019, 06:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf2206f5e5660: Merge #14025: p2p: Remove dead code for nVersion=10300
rABCf2206f5e5660: Merge #14025: p2p: Remove dead code for nVersion=10300
Summary

fa74d3d720 qa: Remove unused deserialization code in msg_version (MarcoFalke)
fa5099ceb7 p2p: Remove dead code for nVersion=10300 (MarcoFalke)

Pull request description:

This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.

Tree-SHA512: 58c131a2730b630ffdc191cd65fe736ed1bd57e184902e2af1b1399443c4654617e68774432016df023434055e85d2e8cd32fb03b40c508c3bb8db6d19427434

Backport of Core PR14025
https://github.com/bitcoin/bitcoin/pull/14025/

Also removed relevant obsolete code from seeder.

Reviewer note: the net_processing changes we made in D333

Test Plan
make check
test_runner.py
./bitcoin-seeder

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14025
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

nakihito created this revision.Nov 15 2019, 06:14
Owners added a reviewer: Restricted Owners Package.Nov 15 2019, 06:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2019, 06:14
teamcity added a comment.Nov 15 2019, 06:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 15 2019, 06:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito planned changes to this revision.Nov 15 2019, 06:15
nakihito requested review of this revision.
nakihito edited the test plan for this revision. (Show Details)
Harbormaster failed remote builds in B8121: Diff 14141!Nov 15 2019, 06:19
teamcity added a comment.Nov 15 2019, 06:19

Build Bitcoin-ABC / Diffs / Diff Testing failed.

teamcity added a comment.Nov 15 2019, 06:19

Build Bitcoin-ABC / Diffs / Diff Testing failed.

nakihito added a child revision: D4436: Add unit tests for CSeederNode::ProcessMessage().Nov 15 2019, 06:25
nakihito mentioned this in D4436: Add unit tests for CSeederNode::ProcessMessage().Nov 15 2019, 06:29
teamcity added a comment.Nov 15 2019, 06:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 15 2019, 06:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 15 2019, 06:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 15 2019, 06:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix requested changes to this revision.Nov 15 2019, 14:41
deadalnix added inline comments.
src/seeder/bitcoin.cpp
122 ↗(On Diff #14141)

It looks like these are also not relevent anymore, as per the test.

This revision now requires changes to proceed.Nov 15 2019, 14:41
nakihito updated this revision to Diff 14150.Nov 15 2019, 15:13

Removed some more obsolete code from the seeder.

teamcity added a comment.Nov 15 2019, 15:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 15 2019, 15:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 15 2019, 15:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 15 2019, 15:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8127: Diff 14150.Nov 15 2019, 15:23
jasonbcox accepted this revision.Nov 15 2019, 17:14
deadalnix accepted this revision.Nov 15 2019, 22:11
This revision is now accepted and ready to land.Nov 15 2019, 22:11
Closed by commit rABCf2206f5e5660: Merge #14025: p2p: Remove dead code for nVersion=10300 (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyNov 15 2019, 22:49
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCf2206f5e5660: Merge #14025: p2p: Remove dead code for nVersion=10300.
nakihito added a commit: rSTAGINGf2206f5e5660: Merge #14025: p2p: Remove dead code for nVersion=10300.Apr 7 2020, 21:41

Revision Contents
Changeset List

PathSize
src/
seeder/
17 lines
test/
functional/
test_framework/
21 lines

Diff 14150

View Options

src/seeder/bitcoin.cpp

Loading...
View Options

test/functional/test_framework/messages.py

Loading...