Page MenuHomePhabricator
Differential D4467

Always create 70 byte signatures with low R values
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2019, 14:48.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING1a5829a4b8bf: Always create 70 byte signatures with low R values
rABC1a5829a4b8bf: Always create 70 byte signatures with low R values
Summary

When extra entropy is not specified by the caller, CKey::Sign will
now always create a signature that has a low R value and is at most
70 bytes. The resulting signature on the stack will be 71 bytes when
the sighash byte is included.

Using low R signatures means that the resulting DER encoded signature
will never need to have additional padding to account for high R
values.

This is a partial backport of Core PR13666 : https://github.com/bitcoin/bitcoin/pull/13666/commits/18dfea0dd082af18dfb02981b7ee1cd44d514388

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13666
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8155
Build 14342: Default Diff Build & Tests
Build 14341: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2019, 14:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2019, 14:48
teamcity added a comment.Nov 19 2019, 15:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.Nov 19 2019, 15:15
teamcity added a comment.Nov 19 2019, 15:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8155: Diff 14200.Nov 19 2019, 15:18
jasonbcox accepted this revision.Nov 20 2019, 01:03
This revision is now accepted and ready to land.Nov 20 2019, 01:03
Closed by commit rABC1a5829a4b8bf: Always create 70 byte signatures with low R values (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 20 2019, 12:35
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1a5829a4b8bf: Always create 70 byte signatures with low R values.
deadalnix added a commit: rSTAGING1a5829a4b8bf: Always create 70 byte signatures with low R values.Apr 7 2020, 21:44
majcosta mentioned this in D12897: [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...).Dec 14 2022, 20:12
majcosta mentioned this in rABC312733002f4a: [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and….Dec 15 2022, 00:29

Revision Contents
Changeset List

PathSize
src/
2 lines
32 lines
test/
51 lines
2 lines
test/
functional/
data/
8 lines
util/
data/
2 lines

Diff 14200

View Options

src/key.h

Loading...
View Options

src/key.cpp

Loading...
View Options

src/test/key_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

test/functional/data/rpc_psbt.json

Loading...
View Options

test/util/data/txcreatesignv2.hex

Loading...