Page MenuHomePhabricator
Differential D4518

[tests] Remove 'account' API from wallet_listreceivedby
ClosedPublic
Actions

Authored by nakihito on Nov 23 2019, 01:40.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2aaed43e2515: [tests] Remove 'account' API from wallet_listreceivedby
rABC2aaed43e2515: [tests] Remove 'account' API from wallet_listreceivedby
Summary

Removes usage of account API from the following functional tests:

  • wallet_listreceivedby.py

Partial backport of Core PR13075
https://github.com/bitcoin/bitcoin/pull/13075/commits/5d536619abda745c298fd827a856df775f223241#diff-ef63894c182111be9ca3357cb3a8a41f

Test Plan
test_runner.py wallet_listreceivedby

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13075
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8243
Build 14511: Default Diff Build & Tests
Build 14510: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 23 2019, 01:40
Owners added a reviewer: Restricted Owners Package.Nov 23 2019, 01:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2019, 01:40
teamcity added a comment.Nov 23 2019, 01:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 23 2019, 01:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8243: Diff 14343.Nov 23 2019, 01:49
nakihito added a child revision: D4519: [wallet] [rpc] Remove getlabeladdress RPC.Nov 23 2019, 01:54
nakihito edited the summary of this revision. (Show Details)Nov 23 2019, 02:32
deadalnix accepted this revision.Nov 23 2019, 15:07
This revision is now accepted and ready to land.Nov 23 2019, 15:07
Closed by commit rABC2aaed43e2515: [tests] Remove 'account' API from wallet_listreceivedby (authored by nakihito). · Explain WhyNov 25 2019, 17:56
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC2aaed43e2515: [tests] Remove 'account' API from wallet_listreceivedby.
nakihito added a commit: rSTAGING2aaed43e2515: [tests] Remove 'account' API from wallet_listreceivedby.Apr 7 2020, 21:49

Revision Contents
Changeset List

PathSize
test/
functional/
7 lines

Diff 14343

View Options

test/functional/wallet_listreceivedby.py

Loading...