As per title.
Details
Details
- Reviewers
freetrader CCulianu - Group Reviewers
Restricted Project - Commits
- rSTAGINGa98fecc68673: Make SCRIPT_ENABLE_SIGHASH_FORKID a mandatory flag.
rABCa98fecc68673: Make SCRIPT_ENABLE_SIGHASH_FORKID a mandatory flag.
make check ../qa/pull-tester/rpc-tests.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- forkidstd
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 710 Build 710: arc lint + arc unit
Event Timeline
| src/script/sign.cpp | ||
|---|---|---|
| 276 | These two are no longer equivalent: new code: MANDATORY_SCRIPT_VERIFY_FLAGS == SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_STRICTENC | SCRIPT_ENABLE_SIGHASH_FORKID, whereas old code was basically: SCRIPT_VERIFY_STRICTENC|SCRIPT_ENABLE_SIHGASH_FORKID Is this intentional? | |
| src/script/sign.cpp | ||
|---|---|---|
| 276 | It is so that we don't need to add more flag in there. The P2SH one doesn't really matter, because this code wants to check the signature. But if we add new mandatory signature checks, they'll get added there automatically. | |
Comment Actions
This looks ok to me.. I'm accepting.
| src/script/sign.cpp | ||
|---|---|---|
| 276 | OK, I am not too familiar with this code so if you say it works because P2SH is ignored, then ok. | |