Page MenuHomePhabricator
Differential D4576

drop 'check3' upgrade-conditional-script-failure for Schnorr multisig
ClosedPublic
Actions

Authored by markblundeberg on Nov 28 2019, 21:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T703: clean up schnorr activations
Commits
rSTAGING7a0f207cdf2f: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig
rABC7a0f207cdf2f: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig
Summary

Now that upgrade has activated, no need for forgiveness.

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
trim_check3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8327
Build 14673: Default Diff Build & Tests
Build 14672: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Nov 28 2019, 21:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2019, 21:49
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 28 2019, 21:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a task: T703: clean up schnorr activations.Nov 28 2019, 21:51
deadalnix accepted this revision.Nov 28 2019, 21:53
This revision is now accepted and ready to land.Nov 28 2019, 21:53
teamcity added a comment.Nov 28 2019, 22:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8327: Diff 14493.Nov 28 2019, 22:00
Closed by commit rABC7a0f207cdf2f: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyNov 29 2019, 03:21
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC7a0f207cdf2f: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING7a0f207cdf2f: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.Apr 7 2020, 21:54
PiRK mentioned this in D17056: [electrum] remove outdated error message.Oct 31 2024, 20:16

Revision Contents
Changeset List

PathSize
src/
13 lines
test/
functional/
10 lines

Diff 14493

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-schnorrmultisig-activation.py

Loading...