Page MenuHomePhabricator
Differential D4628

fuzz: Move deserialize tests to test/fuzz/deserialize.cpp
ClosedPublic
Actions

Authored by Fabien on Dec 4 2019, 12:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4a9588919a79: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp
rABC4a9588919a79: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp
Summary

This will avoid confusion when adding other tests, as test_bitcoin_fuzzy
is not a meaningful name.

Partial backport of core PR15399 (commit fabcfa5):
https://github.com/bitcoin/bitcoin/pull/15399/commits/fabcfa5f0cfe2484fe5cf5ced7cbae34a35c47c9

Depends on D4627.

Test Plan
./configure --disable-ccache --disable-wallet --disable-bench \
  --with-utils=no --with-daemon=no --with-libs=no --with-gui=no \
  --with-seeder=no --enable-fuzz --with-sanitizers=fuzzer,address \
  CC=clang CXX=clang++
make
mkdir -p test/fuzz
cp ../test/fuzz/test_runner.py test/fuzz/
./test/fuzz/test_runner.py -l DEBUG <path_to_corpus>

cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer"
ninja bitcoin-fuzzers link-fuzz-test_runner.py
./test/fuzz/test_runner.py -l DEBUG <path_to_corpus>

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15399_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8399
Build 14815: Default Diff Build & Tests
Build 14814: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 4 2019, 12:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 12:25
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 4 2019, 12:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 4 2019, 12:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8397: Diff 14607.Dec 4 2019, 12:36
Fabien updated this revision to Diff 14609.Dec 4 2019, 13:00

Rebase

teamcity added a comment.Dec 4 2019, 13:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien updated this revision to Diff 14611.Dec 4 2019, 13:02

Rebase

teamcity added a comment.Dec 4 2019, 13:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 4 2019, 13:13

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8401: Diff 14611!Dec 4 2019, 13:13
teamcity added a comment.Dec 4 2019, 13:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8399: Diff 14609.Dec 4 2019, 13:20
Fabien added a child revision: D4629: fuzz: Script validation flags.Dec 4 2019, 15:27
teamcity added a comment.Dec 4 2019, 19:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 4 2019, 19:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8401: Diff 14611.Dec 4 2019, 19:12
deadalnix accepted this revision.Dec 9 2019, 00:41
This revision is now accepted and ready to land.Dec 9 2019, 00:41
Closed by commit rABC4a9588919a79: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMar 19 2020, 15:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4a9588919a79: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Fabien added a commit: rSTAGING4a9588919a79: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.Apr 7 2020, 23:23

Revision Contents
Changeset List

PathSize
src/
40 lines
test/
fuzz/
6 lines
fuzz/
deserialize.cpp
test_bitcoin_fuzzy.cpp
186 lines

Diff 14609

View Options

src/Makefile.test.include

Loading...
View Options

src/test/fuzz/CMakeLists.txt

Loading...
View Options

src/test/fuzz/deserialize.cpp

Loading...
View Options

src/test/test_bitcoin_fuzzy.cpp

Loading...