Page MenuHomePhabricator
Differential D4746

clean up some tests that needlessly use -replayprotectionactivationtime
ClosedPublic
Actions

Authored by markblundeberg on Dec 17 2019, 09:41.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Commits
rSTAGINGd93608fbf65e: clean up some tests that needlessly use -replayprotectionactivationtime
rABCd93608fbf65e: clean up some tests that needlessly use -replayprotectionactivationtime
Summary

(I suppose it was there for activation purposes then didn't get cleaned up)

Test Plan
test_runner.py abc-magnetic-anomaly-mining.py
test_runner.py abc-p2p-fullblocktest.py
test_runner.py abc-transaction-ordering.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replaytest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8589
Build 15166: Default Diff Build & Tests
Build 15165: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 17 2019, 09:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2019, 09:41
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 17 2019, 09:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg edited the test plan for this revision. (Show Details)Dec 17 2019, 09:46
teamcity added a comment.Dec 17 2019, 09:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8589: Diff 14904.Dec 17 2019, 09:52
deadalnix accepted this revision.Dec 17 2019, 23:24
This revision is now accepted and ready to land.Dec 17 2019, 23:24
Closed by commit rABCd93608fbf65e: clean up some tests that needlessly use -replayprotectionactivationtime (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 17 2019, 23:51
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCd93608fbf65e: clean up some tests that needlessly use -replayprotectionactivationtime.
markblundeberg added a task: T653: Clean up past upgrades.Dec 17 2019, 23:57
markblundeberg mentioned this in D4744: fix some tests that rely on free transactions being submittable via RPC.Dec 18 2019, 00:07
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGd93608fbf65e: clean up some tests that needlessly use -replayprotectionactivationtime.Apr 7 2020, 22:07

Revision Contents
Changeset List

Diff 14904

View Options

test/functional/abc-magnetic-anomaly-mining.py

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...