Page MenuHomePhabricator
Differential D475

TRIVIAL: Fix log file message for client name to match CLIENT_NAME
ClosedPublic
Actions

Authored by CCulianu on Aug 20 2017, 22:22.

Details

Reviewers
freetrader
deadalnix
schancel
sickpig
Group Reviewers
Restricted Project
Commits
rSTAGINGeb04e1119ac2: TRIVIAL: Fix log file message for client name to match CLIENT_NAME
rABCeb04e1119ac2: TRIVIAL: Fix log file message for client name to match CLIENT_NAME
Summary

It annoyed me that log files start as such:

2017-08-20 22:03:52 Bitcoin version v0.15.0.0-315c6029f

We are Bitcoin ABC. I looked at the code and it turns out the init message for the log file doesn't use CLIENT_NAME.

With this trivial patch log files will start as follows:

2017-08-20 22:03:52 Bitcoin ABC version v0.15.0.0-315c6029f
Test Plan

make and run bitcoind and see log file

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixlogversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 740
Build 740: arc lint + arc unit

Event Timeline

CCulianu created this revision.Aug 20 2017, 22:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2017, 22:22
CCulianu added a comment.Aug 20 2017, 22:24

Note -- this patch also contains some stuff the linter picked up.

deadalnix requested changes to this revision.Aug 20 2017, 22:52

There are a ton of formatting changes that have nothing to do with anything in there. We are using clang-format-3.8 .

This revision now requires changes to proceed.Aug 20 2017, 22:52
CCulianu updated this revision to Diff 1188.Aug 20 2017, 23:26
CCulianu edited edge metadata.

Undid linter

CCulianu added a comment.Aug 20 2017, 23:26

I was on clang-format-4.0.

Switched to 3.8. It seems to like this file more now.

sickpig accepted this revision as: sickpig.Aug 21 2017, 09:04
freetrader accepted this revision.Aug 21 2017, 10:25
deadalnix accepted this revision.Aug 22 2017, 21:05
This revision is now accepted and ready to land.Aug 22 2017, 21:05
Closed by commit rABCeb04e1119ac2: TRIVIAL: Fix log file message for client name to match CLIENT_NAME (authored by CCulianu, committed by CCulianu). · Explain WhyAug 22 2017, 21:20
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
22 lines

Diff 1187

View Options

src/init.cpp

Loading...