Page MenuHomePhabricator

TRIVIAL: Fix log file message for client name to match CLIENT_NAME
ClosedPublic

Authored by CCulianu on Aug 20 2017, 22:22.

Details

Summary

It annoyed me that log files start as such:

2017-08-20 22:03:52 Bitcoin version v0.15.0.0-315c6029f

We are Bitcoin ABC. I looked at the code and it turns out the init message for the log file doesn't use CLIENT_NAME.

With this trivial patch log files will start as follows:

2017-08-20 22:03:52 Bitcoin ABC version v0.15.0.0-315c6029f
Test Plan

make and run bitcoind and see log file

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixlogversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 741
Build 741: arc lint + arc unit

Event Timeline

Note -- this patch also contains some stuff the linter picked up.

deadalnix requested changes to this revision.Aug 20 2017, 22:52

There are a ton of formatting changes that have nothing to do with anything in there. We are using clang-format-3.8 .

This revision now requires changes to proceed.Aug 20 2017, 22:52
CCulianu edited edge metadata.

Undid linter

I was on clang-format-4.0.

Switched to 3.8. It seems to like this file more now.

This revision is now accepted and ready to land.Aug 22 2017, 21:05
This revision was automatically updated to reflect the committed changes.