Merge #13412: Make ReceivedBlockTransactions return void
ClosedPublic
Actions

Authored by nakihito on Dec 19 2019, 21:49.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING6399a3a3fb2f: Merge #13412: Make ReceivedBlockTransactions return void
rABC6399a3a3fb2f: Merge #13412: Make ReceivedBlockTransactions return void

Summary

fafa27032876832ab2ed9bf0e20e2d448f012179 Make ReceivedBlockTransactions return void (MarcoFalke)

Pull request description:

Instead of always returning `bool{true}` and forcing the caller to handle the return code, make it void and remove "a bunch" of dead code at the call sites.

Tree-SHA512: 10e41461c0516c0441d8b8eedcf6385874355c224b9e9d65e89addb142b4cf3e3be2d4ca0a7f2bd95c76aecdaa8537b6bd2d25631bf804bc42863ad5e84fa271

Backport of Core PR13415
https://github.com/bitcoin/bitcoin/pull/13412/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13412

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8645
Build 15276: Default Diff Build & Tests
Build 15275: arc lint + arc unit

Event Timeline

nakihito created this revision.Dec 19 2019, 21:49

Owners added a reviewer: Restricted Owners Package.Dec 19 2019, 21:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2019, 21:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8645: Diff 15002.Dec 19 2019, 22:18

jasonbcox accepted this revision.Dec 20 2019, 00:52

This revision is now accepted and ready to land.Dec 20 2019, 00:52

Closed by commit rABC6399a3a3fb2f: Merge #13412: Make ReceivedBlockTransactions return void (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyDec 20 2019, 19:27

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC6399a3a3fb2f: Merge #13412: Make ReceivedBlockTransactions return void.

nakihito added a commit: rSTAGING6399a3a3fb2f: Merge #13412: Make ReceivedBlockTransactions return void.Apr 7 2020, 22:12

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

18 lines

Diff 15002

View Options

Merge #13412: Make ReceivedBlockTransactions return voidClosedPublicActions