Page MenuHomePhabricator

Merge #13429: Return the script type from Solver
ClosedPublic

Authored by nakihito on Tue, Jan 14, 00:16.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCbb2c97c5c396: Merge #13429: Return the script type from Solver
Summary

984d72ec659361d8c1a6f3c6864e839a807817a7 Return the script type from Solver (Ben Woosley)

Pull request description:

Because false is synonymous with TX_NONSTANDARD, this conveys the same
information and makes the handling explicitly based on script type,
simplifying each call site.

Prior to this change it was common for the return value to be ignored, or for the
return value and TX_NONSTANDARD to be redundantly handled.

Tree-SHA512: 31864f856b8cb75f4b782d12678070e8b1cfe9665c6f57cfb25e7ac8bcea8a22f9a78d7c8cf0101c841f2a612400666fb91798bffe88de856e98b873703b0965

Backport of Core PR13429 (Modified to fit our codebase)
https://github.com/bitcoin/bitcoin/pull/13429/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Jan 14, 00:16
Owners added a reviewer: Restricted Owners Package.Tue, Jan 14, 00:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 14, 00:16
nakihito planned changes to this revision.Tue, Jan 14, 00:16
nakihito requested review of this revision.Tue, Jan 14, 01:21
deadalnix requested changes to this revision.Tue, Jan 14, 01:24

The change in src/rpc/rawtransaction.cpp is missing.

This revision now requires changes to proceed.Tue, Jan 14, 01:24
nakihito requested review of this revision.Tue, Jan 14, 19:40

The change in src/rpc/rawtransaction.cpp is missing.

This change is for segwit code that was introduced here: https://github.com/bitcoin/bitcoin/pull/12321/files#diff-01aa7d1d32f1b9e5a836c9c411978918R597 so I skipped it.

deadalnix accepted this revision.Wed, Jan 15, 15:18
This revision is now accepted and ready to land.Wed, Jan 15, 15:18