Summary: Replace CAmount typdef with a struct.
AbandonedPublic
Actions

Authored by schancel on Aug 26 2017, 23:15.

Details

Reviewers

deadalnix
CCulianu

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Test Plan

Run unit tests.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

implicit-constructor

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/miner.cpp:1	CFMT	Code style violation
Auto-Fix	src/net_processing.cpp:1	CFMT	Code style violation
Auto-Fix	src/policy/fees.cpp:1	CFMT	Code style violation
Auto-Fix	src/qt/bitcoinamountfield.cpp:1	CFMT	Code style violation
Auto-Fix	src/qt/bitcoinamountfield.h:1	CFMT	Code style violation
Auto-Fix	src/qt/receiverequestdialog.cpp:1	CFMT	Code style violation
Auto-Fix	src/qt/sendcoinsdialog.cpp:1	CFMT	Code style violation
Auto-Fix	src/qt/transactiondesc.cpp:1	CFMT	Code style violation
Auto-Fix	src/qt/transactionrecord.cpp:1	CFMT	Code style violation
Auto-Fix	src/rpc/blockchain.cpp:1	CFMT	Code style violation
Auto-Fix	src/script/bitcoinconsensus.cpp:1	CFMT	Code style violation
Auto-Fix	src/test/policyestimator_tests.cpp:1	CFMT	Code style violation
Auto-Fix	src/txmempool.cpp:1	CFMT	Code style violation
Auto-Fix	src/txmempool.h:1	CFMT	Code style violation
Auto-Fix	src/validation.cpp:1	CFMT	Code style violation
Auto-Fix	src/wallet/rpcwallet.cpp:1	CFMT	Code style violation
Auto-Fix	src/wallet/wallet.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 770
Build 770: arc lint + arc unit

Event Timeline

schancel created this revision.Aug 26 2017, 23:15

Owners added a reviewer: Restricted Owners Package.Aug 26 2017, 23:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2017, 23:15

Fixed a few obvious mistakes (==0 vs !=0)

schancel added inline comments.Aug 26 2017, 23:59

src/qt/bitcoinamountfield.h
32 ↗	(On Diff #1226)	I would like to be able to leave these CAmounts. However, the moc_bitcoinamountfield.cpp that gets generated has errors. I'm not sure what to do about that.

Ok it seems like this very need to be split in chunks. I was able to catch a few errors, but considering how big the thing is, there are probably more. I would proceed as follow :

Get the class working with some unit test that ensure it's behavior is what's expected.
put out a series of diffs that use the new class in various places, one place at the time. This will make errors much more obvious.
Remove the typedef, rename the class CAmount
...
PROFIT

Good suggestions by deadalnix.

I should add just to clarify:

in the 'interim' phase when you are phasing-in the class, call the class CAmountNew or something and leave the old typedef int64_t CAmount, so old code works.
Then one by one replace stuff with CAmountNew -- this is a good strategy to not go nuts as deadalnix suggested.
Then at the end we get rid of the old CAmount typedef and rename CAmountNew -> CAmount (including all the usages of it)

Hope this helps..

This revision now requires changes to proceed.Aug 27 2017, 11:01

schancel added inline comments.Sep 9 2017, 04:09