Prevent shared conf files from failing with different available options in different binaries
ClosedPublic
Actions

Authored by Fabien on Jan 23 2020, 17:12.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING6e971b6abe48: Prevent shared conf files from failing with different available options in…
rABC6e971b6abe48: Prevent shared conf files from failing with different available options in…

Summary

Options that are not available (but known in the source code) will
cause an error if they are specified.
Make these options "available" by adding them to the hidden options
category to prevent conf files from failing when shared between binaries
that have different options available.

Backport of core PR13441.

This required to re-add exceptions to the check-doc linter, but most
of them are going to be removed by a following diff (PR14272).

Test Plan

ninja check
./test/functional/test_runner.py
./bitcoind -help

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13441

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9120
Build 16199: Default Diff Build & Tests
Build 16198: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2020, 17:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2020, 17:12

Herald added a reviewer: deadalnix. · View Herald Transcript

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9120: Diff 15761.Jan 23 2020, 17:19

Fabien added a child revision: D5058: Remove ENABLE_WALLET from libbitcoin_server.a.Jan 24 2020, 08:12

Fabien retitled this revision from Add unavailable options to hidden options category to Prevent shared conf files from failing with different available options in different binaries.Jan 24 2020, 15:50

deadalnix added inline comments.Jan 25 2020, 12:56

src/init.cpp
107	How is this list constructed?

deadalnix added inline comments.Jan 25 2020, 17:09

test/lint/check-doc.py
47	This is not needed in the original PR, why?

Fabien added inline comments.Jan 27 2020, 08:45

src/init.cpp
107	This is the list of wallet arguments from the `WalletInit::AddWalletOptions()` in `src/wallet/init.cpp`. This is still duplicated in Core's current master :(
test/lint/check-doc.py
47	Core didn't remove them in PR13112, which you did during the backport (D3716), so these exceptions have always been there for them. These args are defeating the regex because it's constructed as a list. As mentioned in the summary most of them are deprecated and will be removed in a follow-up backport, then the shorter remaining list can be converted back to use `AddArg()` to clean the `check-doc.py` exceptions if necessary.