Page MenuHomePhabricator
Differential D5057

Merge #13982: refactor: use fs:: over boost::filesystem::
ClosedPublic
Actions

Authored by nakihito on Jan 23 2020, 19:03.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::
rABC8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::
Summary

4b3b85c597 refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

Noticed while investigating #13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

Backport remaining of Core PR13982
https://github.com/bitcoin/bitcoin/pull/13982/

Review note: changes to qt/guiutil.cpp were made in D3219. Changes to
wallet/rpcdump.cpp were made in D1165.

Test Plan
make check
./bitcoind

Verify that debug.log is being written to.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jan 23 2020, 19:03
Owners added a reviewer: Restricted Owners Package.Jan 23 2020, 19:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2020, 19:03
teamcity edited the summary of this revision. (Show Details)Jan 23 2020, 19:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 23 2020, 19:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 23 2020, 19:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9123: Diff 15764.Jan 23 2020, 19:08
Fabien accepted this revision.Jan 24 2020, 09:23
This revision is now accepted and ready to land.Jan 24 2020, 09:23
Closed by commit rABC8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem:: (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyJan 24 2020, 18:02
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::.
nakihito added a commit: rSTAGING8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::.Apr 7 2020, 22:37

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 15776

View Options

src/logging.cpp

Loading...