Make parse_name() fail when passed buffer size = 0
ClosedPublic
Actions

Authored by nakihito on Jan 28 2020, 19:41.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGb9c35cfd6406: Make parse_name() fail when passed buffer size = 0
rABCb9c35cfd6406: Make parse_name() fail when passed buffer size = 0

Summary

Currently, if you pass an output buffer size of 0 to parse_name() it will
cause an overflow when checking the output buffer space. This change causes the
function to short-circuit and fail when passed a buffer size of 0 instead.

Also adds a test for this scenario.

Depends on D4418

Test Plan

ninja check-bitcoin-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Branch

FixWriteBufferGuard

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9177
Build 16306: Default Diff Build & Tests
Build 16305: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 28 2020, 19:41

Owners added a reviewer: Restricted Owners Package.Jan 28 2020, 19:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2020, 19:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9177: Diff 15850.Jan 28 2020, 19:46

jasonbcox added a subscriber: jasonbcox.Jan 28 2020, 23:07

jasonbcox added inline comments.

src/seeder/dns.cpp
68	Do we know what using a -2 return code means vs -1?

nakihito added inline comments.Jan 28 2020, 23:35

src/seeder/dns.cpp
68	https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/seeder/dns.h$32-35 Basically, -2 is output buffer error while -1 is input string error.