Page MenuHomePhabricator
Differential D5410

[wallet] Remove 'account' argument from GetLegacyBalance()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 18:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6c13b2f1e938: [wallet] Remove 'account' argument from GetLegacyBalance()
rABC6c13b2f1e938: [wallet] Remove 'account' argument from GetLegacyBalance()
Summary

GetLegacyBalance() is never called with an account argument.
Remove the argument and helper functions.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/0629de4919d7b8ffdfb09a6f732dc922d9db843b

Depends on D5316

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9706
Build 17305: Default Diff Build & Tests
Build 17304: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 18:39
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 18:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 18:39
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 18:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)Mar 3 2020, 18:42
nakihito added a parent revision: D5316: Merge #14023: Remove accounts rpcs.
teamcity added a comment.Mar 3 2020, 19:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 19:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9706: Diff 16735.Mar 3 2020, 19:12
Fabien accepted this revision.Mar 4 2020, 07:55
This revision is now accepted and ready to land.Mar 4 2020, 07:55
Closed by commit rABC6c13b2f1e938: [wallet] Remove 'account' argument from GetLegacyBalance() (authored by nakihito). · Explain WhyMar 5 2020, 23:54
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC6c13b2f1e938: [wallet] Remove 'account' argument from GetLegacyBalance().
nakihito added a commit: rSTAGING6c13b2f1e938: [wallet] Remove 'account' argument from GetLegacyBalance().Apr 7 2020, 23:14

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines
3 lines
14 lines

Diff 16735

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...