Page MenuHomePhabricator
Differential D5414

[wallet] Don't rewrite accounting entries when reordering wallet transactions and remove WriteAccountingEntry()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 19:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGff6fdf66f74c: [wallet] Don't rewrite accounting entries when reordering wallet transactions…
rABCff6fdf66f74c: [wallet] Don't rewrite accounting entries when reordering wallet transactions…
Summary

Accounting entries are deprecated. Don't rewrite them to the wallet
database when re-ordering transactions.

Also remove unused function.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/3f248a873f941cbcc4d0c24021edcd11e927da98
https://github.com/bitcoin/bitcoin/pull/13825/commits/f992f7fa3eb1438cb01d35af699954ef6f79438a

Depends on D5413

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9710
Build 17313: Default Diff Build & Tests
Build 17312: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 19:07
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 19:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 19:07
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 19:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 19:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9710: Diff 16739.Mar 3 2020, 19:27
nakihito added a child revision: D5416: [wallet] Remove ListAccountCreditDebit().Mar 3 2020, 19:54
nakihito added a child revision: D5418: [wallet] Remove CAccountingEntry class.Mar 3 2020, 20:16
Fabien accepted this revision.Mar 4 2020, 08:00
This revision is now accepted and ready to land.Mar 4 2020, 08:00
Fabien added a comment.Mar 4 2020, 08:03

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*.

Fabien mentioned this in D5416: [wallet] Remove ListAccountCreditDebit().Mar 4 2020, 08:17
nakihito edited the test plan for this revision. (Show Details)Mar 4 2020, 20:43
Closed by commit rABCff6fdf66f74c: [wallet] Don't rewrite accounting entries when reordering wallet transactions… (authored by nakihito). · Explain WhyMar 6 2020, 00:35
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCff6fdf66f74c: [wallet] Don't rewrite accounting entries when reordering wallet transactions….
nakihito added a commit: rSTAGINGff6fdf66f74c: [wallet] Don't rewrite accounting entries when reordering wallet transactions….Apr 7 2020, 23:15

Revision Contents
Changeset List

PathSize
src/
wallet/
14 lines
5 lines
8 lines

Diff 16739

View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...