Page MenuHomePhabricator

[wallet] Don't rewrite accounting entries when reordering wallet transactions and remove WriteAccountingEntry()
ClosedPublic

Authored by nakihito on Mar 3 2020, 19:07.

Details

Summary

Accounting entries are deprecated. Don't rewrite them to the wallet
database when re-ordering transactions.

Also remove unused function.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/3f248a873f941cbcc4d0c24021edcd11e927da98
https://github.com/bitcoin/bitcoin/pull/13825/commits/f992f7fa3eb1438cb01d35af699954ef6f79438a

Depends on D5413

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9710
Build 17313: Default Diff Build & Tests
Build 17312: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 19:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Mar 4 2020, 08:00

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*.