Page MenuHomePhabricator
Differential D5418

[wallet] Remove CAccountingEntry class
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 20:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGaf67f6702662: [wallet] Remove CAccountingEntry class
rABCaf67f6702662: [wallet] Remove CAccountingEntry class
Summary

No longer used

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/7c6f1a1f954512a7dab70e6e0e856a199584b168

Depends on D5411, D5412, D5413, D5414, D5415, D5416

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9714
Build 17321: Default Diff Build & Tests
Build 17320: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 20:16
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 20:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 20:16
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 20:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 20:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 20:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9714: Diff 16746.Mar 3 2020, 20:27
Fabien requested changes to this revision.Mar 4 2020, 08:17
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision now requires changes to proceed.Mar 4 2020, 08:17
nakihito requested review of this revision.Mar 4 2020, 18:55
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien accepted this revision.Mar 5 2020, 07:37
This revision is now accepted and ready to land.Mar 5 2020, 07:37
Closed by commit rABCaf67f6702662: [wallet] Remove CAccountingEntry class (authored by nakihito). · Explain WhyMar 6 2020, 19:23
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCaf67f6702662: [wallet] Remove CAccountingEntry class.
nakihito added a commit: rSTAGINGaf67f6702662: [wallet] Remove CAccountingEntry class.Apr 7 2020, 23:16

Revision Contents
Changeset List

PathSize
src/
wallet/
8 lines
88 lines
42 lines
1 line

Diff 16746

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...