Page MenuHomePhabricator
Differential D5420

[wallet] Remove fromAccount argument from CommitTransaction()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 22:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING43dc709045b2: [wallet] Remove fromAccount argument from CommitTransaction()
rABC43dc709045b2: [wallet] Remove fromAccount argument from CommitTransaction()
Summary

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/0bb1b4e229a869769d81d1531435393a25fcf29

Depends on D5316

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-10
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9718
Build 17329: Default Diff Build & Tests
Build 17328: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 22:21
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 22:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 22:21
teamcity added a comment.Mar 3 2020, 22:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 22:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 22:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9718: Diff 16751.Mar 3 2020, 22:32
Fabien requested changes to this revision.Mar 4 2020, 08:18
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision now requires changes to proceed.Mar 4 2020, 08:18
nakihito requested review of this revision.Mar 4 2020, 19:14
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien accepted this revision.Mar 5 2020, 07:47

The diff is pollution by several unrelated linter formatting changes, but the code looks good.

This revision is now accepted and ready to land.Mar 5 2020, 07:47
nakihito edited the summary of this revision. (Show Details)Mar 5 2020, 19:04
nakihito added a parent revision: D5316: Merge #14023: Remove accounts rpcs.
Closed by commit rABC43dc709045b2: [wallet] Remove fromAccount argument from CommitTransaction() (authored by nakihito). · Explain WhyMar 6 2020, 19:44
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC43dc709045b2: [wallet] Remove fromAccount argument from CommitTransaction().
nakihito added a commit: rSTAGING43dc709045b2: [wallet] Remove fromAccount argument from CommitTransaction().Apr 7 2020, 23:16

Revision Contents
Changeset List

PathSize
src/
interfaces/
1 line
7 lines
qt/
2 lines
wallet/
12 lines
test/
4 lines
3 lines
18 lines

Diff 16751

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...