Page MenuHomePhabricator
Differential D5421

[wallet] Remove strFromAccount and strSentAccount
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 22:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING23fe7e7d5209: [wallet] Remove strFromAccount and strSentAccount
rABC23fe7e7d5209: [wallet] Remove strFromAccount and strSentAccount
Summary

No longer used.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/1031fa0c53f8f19ba27c951979fdfb64f64e70c4
https://github.com/bitcoin/bitcoin/pull/13825/commits/87e8123539f392985dd5778b335d71999b4e2f29

Depends on D5316

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13825-11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9719
Build 17331: Default Diff Build & Tests
Build 17330: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 3 2020, 22:41
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 22:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 22:41
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 22:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 22:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9719: Diff 16754.Mar 3 2020, 22:51
Fabien requested changes to this revision.Mar 4 2020, 08:18
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision now requires changes to proceed.Mar 4 2020, 08:18
nakihito requested review of this revision.Mar 4 2020, 19:19
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien accepted this revision.Mar 5 2020, 07:51
This revision is now accepted and ready to land.Mar 5 2020, 07:51
Closed by commit rABC23fe7e7d5209: [wallet] Remove strFromAccount and strSentAccount (authored by nakihito). · Explain WhyMar 6 2020, 19:52
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC23fe7e7d5209: [wallet] Remove strFromAccount and strSentAccount.
nakihito added a commit: rSTAGING23fe7e7d5209: [wallet] Remove strFromAccount and strSentAccount.Apr 7 2020, 23:16

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines
6 lines
4 lines
11 lines

Diff 16754

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...