Page MenuHomePhabricator
Differential D546

Display if a node is using the cash magic in getpeerinfo
ClosedPublic
Actions

Authored by deadalnix on Sep 17 2017, 14:39.

Details

Reviewers
freetrader
CCulianu
dagurval
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGca89e2e0dde5: Display if a node is using the cash magic in getpeerinfo
rABCca89e2e0dde5: Display if a node is using the cash magic in getpeerinfo
Summary

As per title. This will be useful to know when it is time to disable the legacy magic in the network layer.

Test Plan

Run a node on testnet, call getpeerinfo, ensure presented data are correct.
Modify a node to connect with the new cash magic and ensure it is properly marked as using cash.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
showcashmagic
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 872
Build 872: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 17 2017, 14:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2017, 14:39
schancel accepted this revision.Sep 17 2017, 21:18
schancel added a subscriber: schancel.
schancel added inline comments.
src/net.cpp
673

This looks like the only substantive change aside from adding the flag?

This revision is now accepted and ready to land.Sep 17 2017, 21:18
deadalnix added inline comments.Sep 17 2017, 21:28
src/net.cpp
673

Yes.

Closed by commit rABCca89e2e0dde5: Display if a node is using the cash magic in getpeerinfo (authored by freetrader, committed by deadalnix). · Explain WhySep 17 2017, 21:29
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
5 lines
rpc/
27 lines

Diff 1385

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...