Page MenuHomePhabricator

Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 13 2020, 22:25.

Details

Summary

The last of two patches resulting from breaking the changes
to rpcwallet.cpp into smaller parts.

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcwallethelp.txt

Verify the changes in rpcwallethelp.txt.

Scripts:


D5722diff:

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14796-rpcwallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10205
Build 18235: Default Diff Build & Tests
Build 18234: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 22:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the test plan for this revision. (Show Details)
deadalnix requested changes to this revision.Apr 14 2020, 13:21
deadalnix added a subscriber: deadalnix.

The diff is gigantic, you might ant to refactor a few things and rebase this on top of them to reduce it.

src/wallet/rpcwallet.cpp
3725

Does this work at all? is there a test for that behavior? 'd assume this will do type checking at some point, it'd be great that the breakage is caught here or the doc will 100% end up being incorrect.

This revision now requires changes to proceed.Apr 14 2020, 13:21
src/wallet/rpcwallet.cpp
3725

rpc_fundrawtransaction.py starting on line 653.

Split into two parts (this and D5732).

nakihito retitled this revision from Pass wallet/rpcwallet RPC argument descriptions to RPCHelpMan to Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan.Apr 14 2020, 22:57
nakihito edited the summary of this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Apr 15 2020, 16:02