Paths

Table of Contentst

Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 22:25.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa0950966fd85: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to…
rABCa0950966fd85: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to…

Summary

The last of two patches resulting from breaking the changes
to rpcwallet.cpp into smaller parts.

Partial backport of Core PR14796

Test Plan

mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcwallethelp.txt

Verify the changes in rpcwallethelp.txt.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5722diff:

rpcwallethelp.txt11 KBDownload

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpcwallethelp2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10223
Build 18271: Default Diff Build & Tests
Build 18270: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 13 2020, 22:25

Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 22:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 22:25

nakihito planned changes to this revision.Apr 13 2020, 22:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10205: Diff 18782.Apr 13 2020, 22:37

nakihito requested review of this revision.Apr 13 2020, 23:10

nakihito edited the test plan for this revision. (Show Details)

nakihito mentioned this in D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20

nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:37

The diff is gigantic, you might ant to refactor a few things and rebase this on top of them to reduce it.

src/wallet/rpcwallet.cpp
3725 ↗	(On Diff #18782)	Does this work at all? is there a test for that behavior? 'd assume this will do type checking at some point, it'd be great that the breakage is caught here or the doc will 100% end up being incorrect.

This revision now requires changes to proceed.Apr 14 2020, 13:21

nakihito added inline comments.Apr 14 2020, 20:49

src/wallet/rpcwallet.cpp
3725 ↗	(On Diff #18782)	`rpc_fundrawtransaction.py` starting on line 653.

Split into two parts (this and D5732).

nakihito planned changes to this revision.Apr 14 2020, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito retitled this revision from Pass wallet/rpcwallet RPC argument descriptions to RPCHelpMan to Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan.Apr 14 2020, 22:57

nakihito edited the summary of this revision. (Show Details)

nakihito edited the test plan for this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10223: Diff 18813.Apr 14 2020, 23:05

nakihito requested review of this revision.Apr 14 2020, 23:05

deadalnix accepted this revision.Apr 15 2020, 16:02

This revision is now accepted and ready to land.Apr 15 2020, 16:02

nakihito added a child revision: D5726: Complete PR14796 by cleaning up some old functions and names.Apr 15 2020, 20:39

Rebase.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10237: Diff 18841.Apr 15 2020, 21:27