Page MenuHomePhabricator
Differential D5726

Complete PR14796 by cleaning up some old functions and names
ClosedPublic
Actions

Authored by nakihito on Apr 14 2020, 00:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING02ab89366a5a: Complete PR14796 by cleaning up some old functions and names
rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names
Summary

Finish PR14796 by removing and/or renaming old functions in
rpc/util.

Renaming done with sed "s/ToStringWithArgs/ToString/g" <files>

Depends on D5710, D5712, D5713, D5714. D5716, D5717, D5720, D5722, D5725, D5732

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched finisheddiff

Verify there is no finisheddiff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14796-finish
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10210
Build 18245: Default Diff Build & Tests
Build 18244: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 14 2020, 00:18
Owners added a reviewer: Restricted Owners Package.Apr 14 2020, 00:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2020, 00:18
nakihito planned changes to this revision.Apr 14 2020, 00:18
teamcity edited the summary of this revision. (Show Details)Apr 14 2020, 00:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 14 2020, 00:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 14 2020, 00:20
nakihito edited the summary of this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
nakihito added parent revisions: D5713: Pass rpc/misc RPC argument descriptions to RPCHelpMan, D5712: Pass rpc/net RPC argument descriptions to RPCHelpMan, D5714: Pass rpc/mining RPC argument descriptions to RPCHelpMan, D5710: Pass rpc/server RPC argument descriptions to RPCHelpMan.
teamcity added a comment.Apr 14 2020, 00:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10210: Diff 18789.Apr 14 2020, 00:35
nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:38
deadalnix accepted this revision.Apr 14 2020, 13:22
This revision is now accepted and ready to land.Apr 14 2020, 13:22
nakihito edited the summary of this revision. (Show Details)Apr 15 2020, 20:38
nakihito edited the summary of this revision. (Show Details)
nakihito added parent revisions: D5732: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan, D5722: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan.
nakihito updated this revision to Diff 18846.Apr 15 2020, 22:11

Rebase.

teamcity added a comment.Apr 15 2020, 22:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 15 2020, 22:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10241: Diff 18846.Apr 15 2020, 22:23
Closed by commit rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names (authored by nakihito). · Explain WhyApr 15 2020, 22:28
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.
nakihito added a commit: rSTAGING02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.May 5 2020, 18:58

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
4 lines
64 lines
16 lines
16 lines
26 lines
30 lines
2 lines
27 lines
107 lines
wallet/
20 lines
90 lines

Diff 18789

View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...