Page MenuHomePhabricator

Complete PR14796 by cleaning up some old functions and names
ClosedPublic

Authored by nakihito on Apr 14 2020, 00:18.

Details

Summary

Finish PR14796 by removing and/or renaming old functions in
rpc/util.

Renaming done with sed "s/ToStringWithArgs/ToString/g" <files>

Depends on D5710, D5712, D5713, D5714. D5716, D5717, D5720, D5722, D5725, D5732

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched finisheddiff

Verify there is no finisheddiff.

Scripts:


Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14796-finish
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10210
Build 18245: Default Diff Build & Tests
Build 18244: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 14 2020, 00:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 14 2020, 13:22