Differential D5776

Enable PID file creation on WIN
ClosedPublic
Actions

Authored by deadalnix on Apr 18 2020, 14:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING49cd702189a0: Enable PID file creation on WIN
rABC49cd702189a0: Enable PID file creation on WIN

Summary

Enable PID file creation on Windows

Add available WIN PID function
Consider WIN32 in each relevant case
Add new preprocessor definitions to suppress warning
Update error message for generic OS

Co-authored-by: Jörn Röder <kontakt@joernroeder.de>

This is a backport of Core PR15456

Depends on D5775

Test Plan

make check

Run the win64 build and run bitcon-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15456

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10297
Build 18415: Default Diff Build & Tests
Build 18414: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 18 2020, 14:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2020, 14:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10297: Diff 18940.Apr 18 2020, 14:53

Fabien accepted this revision.Apr 20 2020, 08:41

This revision is now accepted and ready to land.Apr 20 2020, 08:41

Fabien added a child revision: D5779: Refactor: Replace fprintf with tfm::format.Apr 20 2020, 12:14

Closed by commit rABC49cd702189a0: Enable PID file creation on WIN (authored by riordant <riordant@tcd.ie>, committed by deadalnix). · Explain WhyApr 20 2020, 13:04

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC49cd702189a0: Enable PID file creation on WIN.

Fabien removed a child revision: D5779: Refactor: Replace fprintf with tfm::format.Apr 20 2020, 15:21

deadalnix added a commit: rSTAGING49cd702189a0: Enable PID file creation on WIN.May 5 2020, 19:02

Revision Contents
Changeset List

Path

Size

src/

init.cpp

17 lines

Diff 18940

View Options

Enable PID file creation on WINClosedPublicActions