Details

Reviewers

deadalnix
freetrader
CCulianu

Group Reviewers

Restricted Project

Commits

rSTAGINGf51f92b4d015: First pass of a compiling CAmount -> Amount conversion.
rABCf51f92b4d015: First pass of a compiling CAmount -> Amount conversion.

Summary

This patch compiles and runs after converting CFeeRate,
and some of the block processing code.

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

shammah/amount-applied

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 960
Build 960: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 1 2017, 00:28

Harbormaster completed remote builds in B926: Diff 1465.Oct 1 2017, 00:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2017, 00:28

It compiles and passes test, but I want to take a look and make sure where I've converted CAmount -> Amount makes sense.

deadalnix added inline comments.Oct 4 2017, 10:00

src/amount.h
114 ↗	(On Diff #1465)	I don't think it make sense to pass Amount by reference.
129 ↗	(On Diff #1465)	dito
135 ↗	(On Diff #1465)	dito
src/miner.cpp
229 ↗	(On Diff #1465)	Please stick to clang-format 3.8

deadalnix requested changes to this revision.Oct 4 2017, 10:00

This revision now requires changes to proceed.Oct 4 2017, 10:00

Fix reference usage of Amount.
Downgrade to clang-format 3.8

Rebased with fixes.

Harbormaster completed remote builds in B952: Diff 1502.Oct 6 2017, 15:58

schancel added inline comments.Oct 6 2017, 23:21

src/test/transaction_tests.cpp
545 ↗	(On Diff #1502)	This particular formula seemed off to me. Looks like the intent from how it was written is different than actual. Can someone confirm?

deadalnix accepted this revision.Oct 7 2017, 10:55

This revision is now accepted and ready to land.Oct 7 2017, 10:55

Rebase

Harbormaster completed remote builds in B960: Diff 1514.Oct 8 2017, 15:46

Closed by commit rABCf51f92b4d015: First pass of a compiling CAmount -> Amount conversion. (authored by schancel, committed by schancel). · Explain WhyOct 8 2017, 16:27

This revision was automatically updated to reflect the committed changes.

First pass of a compiling CAmount -> Amount conversion.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1514

src/amount.h

src/amount.cpp

src/bench/mempool_eviction.cpp

src/bitcoin-tx.cpp

src/coins.cpp

src/compressor.h

src/compressor.cpp

src/core_write.cpp

src/miner.cpp

src/net_processing.cpp

src/policy/fees.cpp

src/policy/policy.cpp

src/primitives/transaction.h

src/primitives/transaction.cpp

src/qt/coincontroldialog.cpp

src/qt/sendcoinsdialog.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/walletmodel.cpp

src/qt/walletmodeltransaction.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/rawtransaction.cpp

src/rpc/server.h

src/rpc/server.cpp

src/script/interpreter.h

src/script/interpreter.cpp

src/script/sign.h

src/script/sign.cpp

src/test/amount_tests.cpp

src/test/coins_tests.cpp

src/test/compress_tests.cpp

src/test/miner_tests.cpp

src/test/policyestimator_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/test_bitcoin.cpp

src/test/transaction_tests.cpp

src/txmempool.cpp

src/validation.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

First pass of a compiling CAmount -> Amount conversion.
ClosedPublic
Actions

Revision Contents
Changeset List