Page MenuHomePhabricator

First pass of a compiling CAmount -> Amount conversion.
ClosedPublic

Authored by schancel on Oct 1 2017, 00:28.

Details

Summary

This patch compiles and runs after converting CFeeRate,
and some of the block processing code.

Test Plan

make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
shammah/amount-applied
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 960
Build 960: arc lint + arc unit

Event Timeline

It compiles and passes test, but I want to take a look and make sure where I've converted CAmount -> Amount makes sense.

src/amount.h
114 ↗(On Diff #1465)

I don't think it make sense to pass Amount by reference.

129 ↗(On Diff #1465)

dito

135 ↗(On Diff #1465)

dito

src/miner.cpp
229 ↗(On Diff #1465)

Please stick to clang-format 3.8

deadalnix requested changes to this revision.Oct 4 2017, 10:00
This revision now requires changes to proceed.Oct 4 2017, 10:00
schancel edited edge metadata.

Fix reference usage of Amount.
Downgrade to clang-format 3.8

src/test/transaction_tests.cpp
545 ↗(On Diff #1502)

This particular formula seemed off to me. Looks like the intent from how it was written is different than actual. Can someone confirm?

This revision is now accepted and ready to land.Oct 7 2017, 10:55
This revision was automatically updated to reflect the committed changes.