scripted-diff: Replace CCriticalSection with RecursiveMutex
ClosedPublic
Actions

Authored by deadalnix on Apr 24 2020, 16:19.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGddfb85a6c1f0: scripted-diff: Replace CCriticalSection with RecursiveMutex
rABCddfb85a6c1f0: scripted-diff: Replace CCriticalSection with RecursiveMutex

Summary

-BEGIN VERIFY SCRIPT-

Delete outdated alias for RecursiveMutex sed -i -e '/CCriticalSection/d' ./src/sync.h
Replace use of outdated alias with RecursiveMutex sed -i -e 's/CCriticalSection/RecursiveMutex/g' $(git grep -l CCriticalSection)

-END VERIFY SCRIPT-

This is a backport of Core PR17891

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17891

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10378
Build 18577: Default Diff Build & Tests
Build 18576: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 24 2020, 16:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 16:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10378: Diff 19084.Apr 24 2020, 16:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

jasonbcox accepted this revision.Apr 24 2020, 23:33

This revision is now accepted and ready to land.Apr 24 2020, 23:33

Closed by commit rABCddfb85a6c1f0: scripted-diff: Replace CCriticalSection with RecursiveMutex (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyApr 25 2020, 00:16

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCddfb85a6c1f0: scripted-diff: Replace CCriticalSection with RecursiveMutex.

deadalnix added a commit: rSTAGINGddfb85a6c1f0: scripted-diff: Replace CCriticalSection with RecursiveMutex.May 5 2020, 19:08

Revision Contents
Changeset List

Path

Size

src/

2 lines

2 lines

2 lines

2 lines

interfaces/

2 lines

4 lines

34 lines

2 lines

4 lines

2 lines

2 lines

rpc/

server.cpp

2 lines

scheduler.h

2 lines

seeder/

db.h

2 lines

sync.h

1 line

sync.cpp

2 lines

test/

denialofservice_tests.cpp

2 lines

2 lines

2 lines

2 lines

2 lines

util/

system.h

2 lines

validation.h

2 lines

validation.cpp

4 lines

validationinterface.h

2 lines

wallet/

4 lines

2 lines

2 lines

2 lines

Diff 19084

View Options

src/addrman.h

View Options

src/banman.h

View Options

src/chain.h

View Options

src/init.cpp

View Options

src/interfaces/chain.cpp

View Options

src/keystore.h

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/netbase.cpp

View Options

src/rcu.cpp

View Options

src/rpc/server.cpp

View Options

src/scheduler.h

View Options

src/seeder/db.h

View Options

src/sync.h

View Options

src/sync.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/sync_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/timedata.cpp

View Options

src/txmempool.h

View Options

src/util/system.h

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/validationinterface.h

View Options

src/wallet/db.cpp

View Options

src/wallet/wallet.h

View Options

src/wallet/wallet.cpp

View Options

scripted-diff: Replace CCriticalSection with RecursiveMutexClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19084

src/addrman.h

src/banman.h

src/chain.h

src/init.cpp

src/interfaces/chain.cpp

src/keystore.h

src/net.h

src/net.cpp

src/net_processing.cpp

src/netbase.cpp

src/rcu.cpp

src/rpc/server.cpp

src/scheduler.h

src/seeder/db.h

src/sync.h

src/sync.cpp

src/test/denialofservice_tests.cpp

src/test/sync_tests.cpp

src/test/util_tests.cpp

src/timedata.cpp

src/txmempool.h

src/util/system.h

src/validation.h

src/validation.cpp

src/validationinterface.h

src/wallet/db.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

src/warnings.cpp

scripted-diff: Replace CCriticalSection with RecursiveMutex
ClosedPublic
Actions

Revision Contents
Changeset List