Page MenuHomePhabricator
Differential D5828

Merge #15013: test: Avoid race in p2p_timeouts
ClosedPublic
Actions

Authored by jasonbcox on Apr 24 2020, 17:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING64c0efc5696c: Merge #15013: test: Avoid race in p2p_timeouts
rABC64c0efc5696c: Merge #15013: test: Avoid race in p2p_timeouts
Summary

fabcd645b9 test: Avoid racy test p2p_timeouts (MarcoFalke)

Pull request description:

Avoid filesystem/network racyness by sleeping another second. The alternative would be to poll the `debug.log`, but that seems overkill to avoid a sleep in a test that already requires them.

Tree-SHA512: 32de75ecba38426323158fda241e37ffae73806d8c0e60b7ad73fb917e9cd25a3e5f0722cbc6f2f7a5b86501221c317783266bc2e3b4697fb120f05898ccc12d

Backport of Core PR15013

Depends on D5827

Test Plan
test_runner.py p2p_timeouts  # run a few times

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15013
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10382
Build 18585: Default Diff Build & Tests
Build 18584: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 24 2020, 17:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 17:59
teamcity edited the summary of this revision. (Show Details)Apr 24 2020, 17:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 24 2020, 18:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 18:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10382: Diff 19089.Apr 24 2020, 18:09
Fabien accepted this revision.Apr 24 2020, 20:49
This revision is now accepted and ready to land.Apr 24 2020, 20:49
Closed by commit rABC64c0efc5696c: Merge #15013: test: Avoid race in p2p_timeouts (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyApr 24 2020, 22:31
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC64c0efc5696c: Merge #15013: test: Avoid race in p2p_timeouts.
jasonbcox added a commit: rSTAGING64c0efc5696c: Merge #15013: test: Avoid race in p2p_timeouts.May 5 2020, 19:07

Revision Contents
Changeset List

PathSize
test/
functional/
6 lines

Diff 19089

View Options

test/functional/p2p_timeouts.py

Loading...