Page MenuHomePhabricator
Differential D5899

Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 29 2020, 23:49.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGfa91619ce8b3: Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan
rABCfa91619ce8b3: Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan
Summary

Applies the first part of the full changes to wallet/rpcwallet

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcwallet1.diff

Verify changes in rpcwallet1.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

rpcwallet1.diff:

rpcwallet1.diff425 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-rpcwallet2-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10514
Build 18845: Default Diff Build & Tests
Build 18844: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 29 2020, 23:49
Owners added a reviewer: Restricted Owners Package.Apr 29 2020, 23:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2020, 23:49
nakihito planned changes to this revision.Apr 29 2020, 23:49
teamcity edited the summary of this revision. (Show Details)Apr 29 2020, 23:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 29 2020, 23:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 29 2020, 23:52
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 30 2020, 00:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10490: Diff 19269.Apr 30 2020, 00:01
Fabien requested changes to this revision.Apr 30 2020, 07:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcwallet.cpp
188 ↗(On Diff #19269)

Note to reviewers: this one get lost by mistake in D1986.

1004 ↗(On Diff #19269)

Layout

1025 ↗(On Diff #19269)

Dito

This revision now requires changes to proceed.Apr 30 2020, 07:37
nakihito updated this revision to Diff 19307.Apr 30 2020, 16:55

Fixed layout.

teamcity added a comment.Apr 30 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 30 2020, 17:33
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

2020-04-30T17:32:25.868000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200430_173057/feature_uacomment_597/test_framework.log
2020-04-30T17:32:25.868000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200430_173057/feature_uacomment_597' to consolidate all logs
[17:32:54]i:		 [Bitcoin ABC functional tests] wallet_multiwallet.py
[17:32:54]i:			 [wallet_multiwallet.py] [Test Output]
2020-04-30T17:31:55.181000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_569
2020-04-30T17:31:57.289000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 352, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 237, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 165, in main
    self.run_test()
  File "/work/test/functional/wallet_multiwallet.py", line 93, in run_test
    ['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" does not exist')
  File "/work/test/functional/test_framework/test_node.py", line 375, in assert_start_raises_init_error
    'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 152, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Error: Specified -walletdir "wallets" does not exist" does not fully match stderr:
"ErrorSpecified -walletdir "wallets" does not exist"
2020-04-30T17:31:57.339000Z TestFramework (INFO): Stopping nodes
2020-04-30T17:31:57.340000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_569
2020-04-30T17:31:57.340000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_569/test_framework.log
2020-04-30T17:31:57.340000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_569' to consolidate all logs
[17:32:54]i:		 [Bitcoin ABC functional tests] wallet_multiwallet.py --usecli
[17:32:54]i:			 [wallet_multiwallet.py --usecli] [Test Output]
2020-04-30T17:31:45.055000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_563
2020-04-30T17:31:47.052000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 352, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 237, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 165, in main
    self.run_test()
  File "/work/test/functional/wallet_multiwallet.py", line 93, in run_test
    ['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" does not exist')
  File "/work/test/functional/test_framework/test_node.py", line 375, in assert_start_raises_init_error
    'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 152, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Error: Specified -walletdir "wallets" does not exist" does not fully match stderr:
"ErrorSpecified -walletdir "wallets" does not exist"
2020-04-30T17:31:47.103000Z TestFramework (INFO): Stopping nodes
2020-04-30T17:31:47.103000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_563
2020-04-30T17:31:47.103000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_563/test_framework.log
2020-04-30T17:31:47.103000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200430_173057/wallet_multiwallet_563' to consolidate all logs
[17:33:03]W:	 [Step 1/2] Process exited with code 1
[17:33:03]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-cmdline.py
Bitcoin ABC functional tests: feature_blocksdir.py
Bitcoin ABC functional tests: feature_config_args.py
Bitcoin ABC functional tests: feature_includeconf.py
Bitcoin ABC functional tests: feature_logging.py
Bitcoin ABC functional tests: feature_uacomment.py
Bitcoin ABC functional tests: wallet_multiwallet.py
Bitcoin ABC functional tests: wallet_multiwallet.py --usecli

Harbormaster failed remote builds in B10514: Diff 19307!Apr 30 2020, 17:33
nakihito added a child revision: D5922: Finish PR14987 and clean up some functions.Apr 30 2020, 21:27
deadalnix requested changes to this revision.May 1 2020, 00:43
deadalnix added a subscriber: deadalnix.

rebase

This revision now requires changes to proceed.May 1 2020, 00:43
nakihito updated this revision to Diff 19335.May 1 2020, 00:52

Rebased.

teamcity added a comment.May 1 2020, 00:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 1 2020, 01:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10535: Diff 19335.May 1 2020, 01:02
deadalnix accepted this revision.May 1 2020, 12:28
Fabien accepted this revision.May 2 2020, 10:45
This revision is now accepted and ready to land.May 2 2020, 10:45
Closed by commit rABCfa91619ce8b3: Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyMay 4 2020, 17:16
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCfa91619ce8b3: Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGINGfa91619ce8b3: Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan.May 5 2020, 19:18

Revision Contents
Changeset List

PathSize
src/
wallet/
667 lines

Diff 19307

View Options

src/wallet/rpcwallet.cpp

Loading...