Page MenuHomePhabricator

[backport#15638] [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp
ClosedPublic

Authored by majcosta on May 6 2020, 19:31.

Details

Summary

rpc/rawtransaction.cpp moves to libbitcoin_server since it should not be
accessed by non-node libraries. The utility following utility methods
move to their own unit rpc/rawtransaction_util since they need to be
accessed by non-node libraries:

  • ConstructTransaction
  • TxInErrorToJSON
  • SignTransaction

https://github.com/bitcoin/bitcoin/pull/15638/commits/0509465542d63a5bbe7296f283f44dd491e74f78


Depends on D5979

This is a partial backport of Core PR15638

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15638
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10620
Build 19048: Default Diff Build & Tests
Build 19047: arc lint + arc unit

Event Timeline

majcosta requested review of this revision.May 6 2020, 19:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 6 2020, 19:55