Differential D6037

[cleanup] remove unused function/correct comment
AbandonedPublic
Actions

Authored by majcosta on May 11 2020, 20:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

static bool GetPubKey in script/sign.cpp is unused
since D5764 regtest requires transactions to be standard by default, comment in validation.cpp is inaccurate.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

code_cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10703
Build 19202: Default Diff Build & Tests
Build 19201: arc lint + arc unit

Event Timeline

majcosta created this revision.May 11 2020, 20:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 20:58

majcosta requested review of this revision.May 11 2020, 20:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10703: Diff 19925.May 11 2020, 21:07

deadalnix accepted this revision.May 11 2020, 21:43

This revision is now accepted and ready to land.May 11 2020, 21:43

majcosta abandoned this revision.May 13 2020, 17:37

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

26 lines

validation.cpp

2 lines

Diff 19925

View Options

src/script/sign.cpp