Page MenuHomePhabricator
Differential D6070

[backport#15404] Address test todos by removing -txindex to nodes.
ClosedPublic
Actions

Authored by majcosta on May 14 2020, 01:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING345b8e56567e: [backport#15404] Address test todos by removing -txindex to nodes.
rABC345b8e56567e: [backport#15404] Address test todos by removing -txindex to nodes.
Summary

Originally added when updating getrawtransaction to stop searching unspent utxos.

https://github.com/bitcoin/bitcoin/pull/15404/commits/8e4b4f683a0b342cec24cd51b1e98433034ea2ea

Depends on D6069

This is a backport of Core PR15404

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 14 2020, 01:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 01:59
majcosta requested review of this revision.May 14 2020, 01:59
teamcity edited the summary of this revision. (Show Details)May 14 2020, 01:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 01:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 01:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 02:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 02:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 02:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 02:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10762: Diff 20046.May 14 2020, 02:13
Fabien accepted this revision.May 14 2020, 16:27
This revision is now accepted and ready to land.May 14 2020, 16:27
Closed by commit rABC345b8e56567e: [backport#15404] Address test todos by removing -txindex to nodes. (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by majcosta). · Explain WhyMay 16 2020, 11:38
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC345b8e56567e: [backport#15404] Address test todos by removing -txindex to nodes..
majcosta added a commit: rSTAGING345b8e56567e: [backport#15404] Address test todos by removing -txindex to nodes..

Revision Contents
Changeset List

PathSize
doc/
3 lines
test/
functional/
37 lines
12 lines
1 line
test_framework/
4 lines
3 lines
8 lines

Diff 20155

View Options

doc/REST-interface.md

Loading...
View Options

test/functional/interface_rest.py

Loading...
View Options

test/functional/rpc_psbt.py

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...