Page MenuHomePhabricator

[backport#15247] qa: Use wallet to retrieve raw transactions
ClosedPublic

Authored by majcosta on May 14 2020, 01:41.

Details

Summary

Merge #15247: qa: Use wallet to retrieve raw transactions

fa5278a419 qa: Use wallet to retrieve raw transactions (MarcoFalke)
fa2198328e qa: Style-only fixes in touched files (MarcoFalke)

Pull request description:

Instead of asking the coin database and block storage about a transaction, pull it directly from th$
This refactoring only makes sense in light of #15159.
<sub>This product may contain minor stylistic cleanups


Depends on D6062

This is a backport of Core PR15247

Test Plan
./test_runner.py wallet_abandonconflict.py wallet_basic.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 14 2020, 01:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 01:41
majcosta requested review of this revision.May 14 2020, 01:41
teamcity edited the summary of this revision. (Show Details)May 14 2020, 01:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.May 14 2020, 16:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_abandonconflict.py
40 ↗(On Diff #20045)

Please add a comment to explain that the returned fee is negative.

This revision is now accepted and ready to land.May 14 2020, 16:17