[backport#15159#15404] [RPC] Remove lookup to UTXO set from GetTransaction
AbandonedPublic
Actions

Authored by majcosta on May 13 2020, 17:37.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

[RPC] Update getrawtransaction interface https://github.com/bitcoin/bitcoin/pull/15159/commits/04da9f4834e1651da65ceb6379950cef9450591c (Amiti Uttarwar)

Address test todos by removing -txindex to nodes. https://github.com/bitcoin/bitcoin/pull/15404/commits/8e4b4f683a0b342cec24cd51b1e98433034ea2ea (Amiti Uttarwar)

Depends on D6058

This is a backport of Core PR15159 and PR15404 due to PR15159 breaking rpc_psbt.py functional test

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13932

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10751
Build 19315: Default Diff Build & Tests
Build 19314: Build without Wallet
Build 19313: Build with clang-10
Build 19312: arc lint + arc unit

Event Timeline

majcosta created this revision.May 13 2020, 17:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 17:37

majcosta requested review of this revision.May 13 2020, 17:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10744: Diff 20008.May 13 2020, 17:49

The diff title doesn't match the change. It looks like we're missing a backport or something? Check out https://github.com/bitcoin/bitcoin/pull/15159

This revision now requires changes to proceed.May 13 2020, 18:13

majcosta abandoned this revision.May 13 2020, 20:44

added missing PR15159 (https://github.com/bitcoin/bitcoin/pull/15159/commits/04da9f4834e1651da65ceb6379950cef9450591c)

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

majcosta retitled this revision from [backport#15404] Address test todos by removing -txindex to nodes. Originally added when updating getrawtransaction to stop searching unspent utxos. to [backport#15159#15404] [RPC] Remove lookup to UTXO set from GetTransaction.May 13 2020, 21:38

majcosta edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

majcosta planned changes to this revision.May 13 2020, 21:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10751: Diff 20024.May 13 2020, 21:47

majcosta abandoned this revision.May 13 2020, 22:36