Page MenuHomePhabricator

[backport#15159] [RPC] Update getrawtransaction interface
ClosedPublic

Authored by majcosta on May 13 2020, 22:38.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 13 2020, 22:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 22:38
majcosta requested review of this revision.May 13 2020, 22:38
teamcity edited the summary of this revision. (Show Details)May 13 2020, 22:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested changes to this revision.May 14 2020, 00:05
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/rpc/rawtransaction.cpp
109–168 ↗(On Diff #20025)

Restore.

src/validation.cpp
709 ↗(On Diff #20025)

Any reason for the divergence?

test/functional/mining_prioritisetransaction.py
28 ↗(On Diff #20025)

I don't see a getrawtransaction call in this file?

This revision now requires changes to proceed.May 14 2020, 00:05
majcosta updated this revision to Diff 20040.May 14 2020, 01:29

rebase and made comment on mining_prioritisetransaction more informative about why it still needs -txindex

nakihito accepted this revision.May 14 2020, 01:32
This revision is now accepted and ready to land.May 14 2020, 01:32