Page MenuHomePhabricator
Differential D6062

[backport#15159] [RPC] Update getrawtransaction interface
ClosedPublic
Actions

Authored by majcosta on May 13 2020, 22:38.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGb57c44a940de: [backport#15159] [RPC] Update getrawtransaction interface
rABCb57c44a940de: [backport#15159] [RPC] Update getrawtransaction interface
Summary

https://github.com/bitcoin/bitcoin/pull/15159/commits/04da9f4834e1651da65ceb6379950cef9450591c

Depends on D6058

This is a backport of Core PR15159

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 13 2020, 22:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 22:38
majcosta requested review of this revision.May 13 2020, 22:38
teamcity edited the summary of this revision. (Show Details)May 13 2020, 22:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 13 2020, 22:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 13 2020, 22:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 13 2020, 22:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 13 2020, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 13 2020, 22:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 13 2020, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10752: Diff 20025.May 13 2020, 22:55
nakihito requested changes to this revision.May 14 2020, 00:05
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/rpc/rawtransaction.cpp
109–168 ↗(On Diff #20025)

Restore.

src/validation.cpp
709 ↗(On Diff #20025)

Any reason for the divergence?

test/functional/mining_prioritisetransaction.py
28 ↗(On Diff #20025)

I don't see a getrawtransaction call in this file?

This revision now requires changes to proceed.May 14 2020, 00:05
majcosta updated this revision to Diff 20040.May 14 2020, 01:29

rebase and made comment on mining_prioritisetransaction more informative about why it still needs -txindex

teamcity added a comment.May 14 2020, 01:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

nakihito accepted this revision.May 14 2020, 01:32
This revision is now accepted and ready to land.May 14 2020, 01:32
teamcity added a comment.May 14 2020, 01:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 01:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 01:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

majcosta added a child revision: D6069: [backport#15247] qa: Use wallet to retrieve raw transactions.May 14 2020, 01:41
teamcity added a comment.May 14 2020, 01:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 01:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10758: Diff 20040.May 14 2020, 01:56
Closed by commit rABCb57c44a940de: [backport#15159] [RPC] Update getrawtransaction interface (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by majcosta). · Explain WhyMay 16 2020, 11:33
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb57c44a940de: [backport#15159] [RPC] Update getrawtransaction interface.
majcosta added a commit: rSTAGINGb57c44a940de: [backport#15159] [RPC] Update getrawtransaction interface.May 16 2020, 11:35

Revision Contents
Changeset List

Diff 20151

View Options

doc/release-notes.md

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/interface_rest.py

Loading...
View Options

test/functional/mining_prioritisetransaction.py

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...
View Options

test/functional/rpc_psbt.py

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...