Page MenuHomePhabricator

[backport#13932] Implement analyzepsbt RPC and tests

Authored by majcosta on May 13 2020, 17:15.

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 13 2020, 17:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 17:15
majcosta requested review of this revision.May 13 2020, 17:15
teamcity edited the summary of this revision. (Show Details)May 13 2020, 17:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested changes to this revision.May 13 2020, 19:39
nakihito added a subscriber: nakihito.
nakihito added inline comments.
1886–1887 ↗(On Diff #20005)


2041 ↗(On Diff #20005)


137 ↗(On Diff #20005)

Where does this change come from?

282 ↗(On Diff #20005)

You can either leave the trailing comment out or move it above to its own line.

This revision now requires changes to proceed.May 13 2020, 19:39
majcosta updated this revision to Diff 20021.May 13 2020, 20:56

addressed comments

nakihito accepted this revision.May 13 2020, 21:13
This revision is now accepted and ready to land.May 13 2020, 21:13
majcosta added inline comments.May 13 2020, 21:24
137 ↗(On Diff #20021)

@nakihito sorry, didn't know pushing a diff would erase inline comments where I made no changes.

this section is actually how the core code looks now. the analyzepsbt function just won't pass the tests without the \\ Look for pubkey in pubkey list part of the GetPubKey function.

deadalnix accepted this revision.May 15 2020, 18:55