Page MenuHomePhabricator

[backport#13932] Implement analyzepsbt RPC and tests
ClosedPublic

Authored by majcosta on May 13 2020, 17:15.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested changes to this revision.May 13 2020, 19:39
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/rpc/rawtransaction.cpp
1886–1887 ↗(On Diff #20005)

Remove.

2041 ↗(On Diff #20005)

int(size)

src/script/sign.cpp
137 ↗(On Diff #20005)

Where does this change come from?

test/functional/rpc_psbt.py
282 ↗(On Diff #20005)

You can either leave the trailing comment out or move it above to its own line.

This revision now requires changes to proceed.May 13 2020, 19:39
This revision is now accepted and ready to land.May 13 2020, 21:13
src/script/sign.cpp
137 ↗(On Diff #20021)

@nakihito sorry, didn't know pushing a diff would erase inline comments where I made no changes.

this section is actually how the core code looks now. the analyzepsbt function just won't pass the tests without the \\ Look for pubkey in pubkey list part of the GetPubKey function.