[backport#13932] Implement analyzepsbt RPC and tests
ClosedPublic
Actions

Authored by majcosta on May 13 2020, 17:15.

Details

Reviewers

nakihito
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING397f2c93160e: [backport#13932] Implement analyzepsbt RPC and tests
rABC397f2c93160e: [backport#13932] Implement analyzepsbt RPC and tests

Summary

https://github.com/bitcoin/bitcoin/pull/13932/commits/540729ef4bf1b6c6da1ec795e441d2ce56a9a58b

This completes the backport of Core PR13932

Test Plan

cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10750
Build 19311: Default Diff Build & Tests
Build 19310: Build without Wallet
Build 19309: Build with clang-10
Build 19308: arc lint + arc unit

Event Timeline

majcosta created this revision.May 13 2020, 17:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 17:15

majcosta requested review of this revision.May 13 2020, 17:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10743: Diff 20005.May 13 2020, 17:26

majcosta added a child revision: D6059: [backport#15159#15404] [RPC] Remove lookup to UTXO set from GetTransaction.May 13 2020, 17:37

nakihito requested changes to this revision.May 13 2020, 19:39

nakihito added a subscriber: nakihito.

nakihito added inline comments.

src/rpc/rawtransaction.cpp
1886–1887 ↗	(On Diff #20005)	Remove.
2041 ↗	(On Diff #20005)	`int(size)`
src/script/sign.cpp
137 ↗	(On Diff #20005)	Where does this change come from?
test/functional/rpc_psbt.py
282 ↗	(On Diff #20005)	You can either leave the trailing comment out or move it above to its own line.

This revision now requires changes to proceed.May 13 2020, 19:39

addressed comments

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10750: Diff 20021.May 13 2020, 21:05

nakihito accepted this revision.May 13 2020, 21:13

This revision is now accepted and ready to land.May 13 2020, 21:13

majcosta added inline comments.May 13 2020, 21:24

src/script/sign.cpp
137	@nakihito sorry, didn't know pushing a diff would erase inline comments where I made no changes. this section is actually how the core code looks now. the analyzepsbt function just won't pass the tests without the `\\ Look for pubkey in pubkey list` part of the GetPubKey function.