Page MenuHomePhabricator
Differential D6163

[backport#15957] Show loaded wallets as disabled in open menu instead of nothing
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 14:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6c61c44980a5: [backport#15957] Show loaded wallets as disabled in open menu instead of nothing
rABC6c61c44980a5: [backport#15957] Show loaded wallets as disabled in open menu instead of nothing
Summary

https://github.com/bitcoin/bitcoin/pull/15957/commits/c3ef63a52f304a600fff1f9c7caa5cb804d41d43

This is a backport of Core PR15957

Test Plan
ninja check
./src/qt/bitcoin-qt -regtest

Focus the Open wallet menu item, see that [default wallet] appears, greyed out because it is loaded.

Empty out the std::vector<std::string> wallets right before the for-loop that iterates through it, compile and run the above again, see that focusing the Open wallet menu item shows No wallets available

Diff Detail

Event Timeline

majcosta created this revision.May 20 2020, 14:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 14:36
majcosta requested review of this revision.May 20 2020, 14:36
teamcity edited the summary of this revision. (Show Details)May 20 2020, 14:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 14:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 14:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 14:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 14:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 14:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 14:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10890: Diff 20356.May 20 2020, 14:51
majcosta added a child revision: D6167: [backport#15195] interfaces: Add remove to Wallet.May 20 2020, 17:28
deadalnix accepted this revision.May 20 2020, 17:37
deadalnix added a subscriber: deadalnix.

The test plan does not cover the

No wallets available

Part of the code. Make sure you test this before landing.

src/qt/bitcoingui.cpp
462

setEnables(false).

Because creating a setDisabled would have costed billions, probably...

This revision is now accepted and ready to land.May 20 2020, 17:37
majcosta edited the test plan for this revision. (Show Details)May 20 2020, 18:07
Closed by commit rABC6c61c44980a5: [backport#15957] Show loaded wallets as disabled in open menu instead of nothing (authored by MeshCollider <dobsonsa68@gmail.com>, committed by majcosta). · Explain WhyMay 20 2020, 18:11
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC6c61c44980a5: [backport#15957] Show loaded wallets as disabled in open menu instead of nothing.
majcosta added a commit: rSTAGING6c61c44980a5: [backport#15957] Show loaded wallets as disabled in open menu instead of nothing.May 20 2020, 18:15

Revision Contents
Changeset List

PathSize
src/
qt/
20 lines

Diff 20356

View Options

src/qt/bitcoingui.cpp

Loading...