Page MenuHomePhabricator

[backport#15957] Show loaded wallets as disabled in open menu instead of nothing

Authored by majcosta on May 20 2020, 14:36.


Test Plan
ninja check
./src/qt/bitcoin-qt -regtest

Focus the Open wallet menu item, see that [default wallet] appears, greyed out because it is loaded.

Empty out the std::vector<std::string> wallets right before the for-loop that iterates through it, compile and run the above again, see that focusing the Open wallet menu item shows No wallets available

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a subscriber: deadalnix.

The test plan does not cover the

No wallets available

Part of the code. Make sure you test this before landing.



Because creating a setDisabled would have costed billions, probably...

This revision is now accepted and ready to land.May 20 2020, 17:37