Page MenuHomePhabricator

[backport#15957] Show loaded wallets as disabled in open menu instead of nothing
ClosedPublic

Authored by majcosta on May 20 2020, 14:36.

Details

Summary
Test Plan
ninja check
./src/qt/bitcoin-qt -regtest

Focus the Open wallet menu item, see that [default wallet] appears, greyed out because it is loaded.

Empty out the std::vector<std::string> wallets right before the for-loop that iterates through it, compile and run the above again, see that focusing the Open wallet menu item shows No wallets available

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 20 2020, 14:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 14:36
majcosta requested review of this revision.May 20 2020, 14:36
teamcity edited the summary of this revision. (Show Details)May 20 2020, 14:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.May 20 2020, 17:37
deadalnix added a subscriber: deadalnix.

The test plan does not cover the

No wallets available

Part of the code. Make sure you test this before landing.

src/qt/bitcoingui.cpp
462 ↗(On Diff #20356)

setEnables(false).

Because creating a setDisabled would have costed billions, probably...

This revision is now accepted and ready to land.May 20 2020, 17:37
majcosta edited the test plan for this revision. (Show Details)May 20 2020, 18:07