[backport#15195] interfaces: Add remove to Wallet
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 17:28.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING30b314cb2e35: [backport#15195] interfaces: Add remove to Wallet
rABC30b314cb2e35: [backport#15195] interfaces: Add remove to Wallet

Summary

https://github.com/bitcoin/bitcoin/pull/15195/commits/f6122abe03699423faca29035f16f3afc527f4d3

Depends on D6163

Partial backport of Core PR15195

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10894
Build 19851: Default Diff Build & Tests
Build 19850: Build without Wallet
Build 19849: Build with clang-10
Build 19848: arc lint + arc unit

Event Timeline

majcosta created this revision.May 20 2020, 17:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 17:28

majcosta requested review of this revision.May 20 2020, 17:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

majcosta added a child revision: D6168: [backport#15195] gui: Add closeWallet to WalletController.May 20 2020, 17:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix accepted this revision.May 20 2020, 17:35

This revision is now accepted and ready to land.May 20 2020, 17:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10894: Diff 20362.May 20 2020, 17:41

majcosta retitled this revision from [backport#15195]interfaces: Add remove to Wallet to [backport#15195] interfaces: Add remove to Wallet.May 20 2020, 18:12

Closed by commit rABC30b314cb2e35: [backport#15195] interfaces: Add remove to Wallet (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 20 2020, 18:12

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC30b314cb2e35: [backport#15195] interfaces: Add remove to Wallet.

majcosta added a commit: rSTAGING30b314cb2e35: [backport#15195] interfaces: Add remove to Wallet.May 20 2020, 18:15