Partial backport of Core PR15644
- Group Reviewers
- rABC304dfe481af7: [backport#15644] Simplify orphan processing in preparation for interruptibility
ninja check ./test/functional/test_runner.py --extended
There is clearly some txid confusion that needs to be cleared before this can proceed.
|2815 ↗||(On Diff #20501)|
Why do you need a conversion here? This is wrong, that means you got to convert some code to use txid first (or worse, this isn't not meant to be a txid and then you created a problem).
|2832 ↗||(On Diff #20501)|
Is it the hash of the txid?
|2809 ↗||(On Diff #20536)|
this is what is actually happening under the hood: we're doing a narrowing conversion from size_t (unsigned long int on my machine) to uint32_t (unsigned int)
the list initializer forces us to be be explicit about that and will error out if you remove the static_cast