Page MenuHomePhabricator

Move GenerateSelectSet logic to private method.
ClosedPublic

Authored by nakihito on Jun 8 2020, 20:07.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC716ac6e899ad: Move GenerateSelectSet logic to private method.
Summary

This separates the socket event collection logic from the logic
deciding which events we're interested in at all.

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/7e403c0ae705455aa66f7df9a9a99f462fd4e9a8

Depends on D6459

Test Plan
ninja
ninja check-all
src/bitcoind -debug=net

Verify normal node connection behavior

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 20:07
nakihito requested review of this revision.Jun 8 2020, 20:07
nakihito planned changes to this revision.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Jun 8 2020, 22:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
1284 ↗(On Diff #21110)

Nit: Comment on its line

This revision is now accepted and ready to land.Jun 9 2020, 06:43