Page MenuHomePhabricator
Differential D6616

[backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset
ClosedPublic
Actions

Authored by majcosta on Jun 16 2020, 21:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc8309573b923: [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset
Summary

https://github.com/bitcoin/bitcoin/pull/15427/commits/fb90ec3c33e824f5abb6a68452c683d6ce8b3e4a

Partial backport of Core PR15427

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 16 2020, 21:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 21:37
majcosta requested review of this revision.Jun 16 2020, 21:37
teamcity edited the summary of this revision. (Show Details)Jun 16 2020, 21:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta retitled this revision from [backport#15427 1/4] Abstract out EvalDescriptorStringOrObject from scantxoutset to [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset.Jun 16 2020, 21:38
Harbormaster completed remote builds in B11535: Diff 21476.Jun 16 2020, 21:48
Fabien accepted this revision.Jun 17 2020, 09:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/util.h
96 ↗(On Diff #21476)

Fix layout:

/**
 * Lorem ipsum
 * dolor sit amet
 */
This revision is now accepted and ready to land.Jun 17 2020, 09:37
majcosta added a child revision: D6624: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT.Jun 17 2020, 17:46
Closed by commit rABCc8309573b923: [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 23 2020, 18:33
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc8309573b923: [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset.

Revision Contents
Changeset List

PathSize
src/
rpc/
53 lines
10 lines
49 lines

Diff 21659

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...